affaan-m/ECC · error · anyhow::Error

minimum samples must be positive

Error message

minimum samples must be positive

What it means

PromotionPolicy::validate rejects a policy whose min_samples is zero, since a promotion comparison must require at least one paired sample to be meaningful. It fires on a degenerate policy definition before compare runs.

Source

Thrown at ecc2/src/harness_eval.rs:508

    pub min_mean_delta: f64,
    pub min_win_rate: f64,
}

#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
pub struct Comparison {
    pub passed: bool,
    pub sample_count: usize,
    pub candidate_mean: f64,
    pub baseline_mean: f64,
    pub mean_delta: f64,
    pub win_rate: f64,
    pub failures: Vec<String>,
}

impl PromotionPolicy {
    pub fn validate(self) -> Result<()> {
        if self.min_samples == 0 {
            bail!("minimum samples must be positive");
        }
        if !self.min_mean_delta.is_finite() {
            bail!("minimum mean delta must be finite");
        }
        if !self.min_win_rate.is_finite() || !(0.0..=1.0).contains(&self.min_win_rate) {
            bail!("minimum win rate must be between 0 and 1");
        }
        Ok(())
    }

    pub fn compare(self, samples: &[PairedSample]) -> Result<Comparison> {
        self.validate()?;
        if samples.is_empty() {
            bail!("samples cannot be empty");
        }
        if samples
            .iter()
            .map(|sample| sample.seed)

View on GitHub (pinned to 06c5e118c4)

Solutions

1. Set minimum samples to a positive integer greater than zero.
2. Fix config parsing that coerced the value to 0 or a negative number.

When it happens

Trigger: Thrown at ecc2/src/harness_eval.rs:508 when the library encounters an invalid state.

Common situations: See trigger scenarios.

AI-assisted analysis of affaan-m/ECC@06c5e118c4 (2026-08-18). Data as JSON: /api/errors/db7709b7ee9be4bd. Report an issue: GitHub.