{"record":{"id":"0154e8680593f679","repo":"nexu-io/open-design","slug":"running-left-mirror-job-is-missing-an-approved-mir","errorCode":null,"errorMessage":"running-left mirror job is missing an approved mirror_decision; use derive_running_left_from_running_right.py after visual review","messagePattern":"running-left mirror job is missing an approved mirror_decision; use derive_running_left_from_running_right\\.py after visual review","errorType":"exception","errorClass":"SystemExit","httpStatus":null,"severity":"error","filePath":"skills/hatch-pet/scripts/finalize_pet_run.py","lineNumber":88,"sourceCode":"    source_hash = file_sha256(source)\n    output_hash = file_sha256(output)\n    if source_hash != expected_hash:\n        raise SystemExit(f\"job {job_id} source image hash does not match imagegen-jobs.json\")\n    if output_hash != expected_hash:\n        raise SystemExit(\n            f\"job {job_id} decoded output does not match its recorded source image; \"\n            \"do not rewrite decoded visual outputs locally\"\n        )\n\n\ndef validate_mirror_hash(job: dict[str, object], *, source: Path, output: Path, job_id: str) -> None:\n    if job_id != \"running-left\":\n        raise SystemExit(f\"job {job_id} may not use deterministic mirror provenance\")\n    if job.get(\"derived_from\") != \"running-right\":\n        raise SystemExit(\"running-left mirror job must derive from running-right\")\n    decision = job.get(\"mirror_decision\")\n    if not isinstance(decision, dict) or decision.get(\"approved\") is not True:\n        raise SystemExit(\n            \"running-left mirror job is missing an approved mirror_decision; \"\n            \"use derive_running_left_from_running_right.py after visual review\"\n        )\n\n    expected_source_hash = job.get(\"source_sha256\")\n    expected_output_hash = job.get(\"output_sha256\")\n    if not isinstance(expected_source_hash, str) or not expected_source_hash:\n        raise SystemExit(\"running-left mirror job is missing source_sha256\")\n    if not isinstance(expected_output_hash, str) or not expected_output_hash:\n        raise SystemExit(\"running-left mirror job is missing output_sha256\")\n    if not source.is_file():\n        raise SystemExit(f\"running-left mirror source image no longer exists: {source}\")\n    if not output.is_file():\n        raise SystemExit(f\"running-left mirrored output is missing: {output}\")\n    if source.name != \"running-right.png\" or source.parent.name != \"decoded\":\n        raise SystemExit(\"running-left mirror source must be decoded/running-right.png\")\n    if output.name != \"running-left.png\" or output.parent.name != \"decoded\":\n        raise SystemExit(\"running-left mirror output must be decoded/running-left.png\")","sourceCodeStart":70,"sourceCodeEnd":106,"githubUrl":"https://github.com/nexu-io/open-design/blob/5be4028344c2eb4c667c5a97bda8f750c5597ef7/skills/hatch-pet/scripts/finalize_pet_run.py#L70-L106","documentation":"A mirror job must carry mirror_decision: {\"approved\": true, ...} written by the derive script after explicit visual confirmation (--confirm-appropriate-mirror + --decision-note). This enforces that mirroring was a deliberate, reviewed decision rather than a hand-edit.","triggerScenarios":"mirror_decision is absent, not a dict, or its approved field is not exactly True — typically because the manifest was edited to mark running-left complete without running the derive script.","commonSituations":"Skipping the derive script and hand-writing status=complete; an interrupted derive that wrote provenance but not the decision; copy-pasting from another job.","solutions":["Run derive_running_left_from_running_right.py with --confirm-appropriate-mirror and a non-empty --decision-note, after visually verifying the right strip mirrors cleanly.","Do not hand-write mirror_decision — the derive script produces it atomically with the hashes.","Re-run finalize_pet_run.py."],"exampleFix":null,"handlingStrategy":"type-guard","validationCode":"import json\nfrom pathlib import Path\n\nmanifest = json.loads(Path(\"<run_dir>/imagegen-jobs.json\").read_text())\nleft = next(j for j in manifest[\"jobs\"] if j.get(\"id\") == \"running-left\")\nif left.get(\"source_provenance\") == \"deterministic-mirror\":\n    decision = left.get(\"mirror_decision\")\n    assert isinstance(decision, dict) and decision.get(\"approved\") is True, \\\n        \"run derive_running_left_from_running_right.py with --confirm-appropriate-mirror first\"","typeGuard":"def mirror_decision_ok(left_job: dict) -> bool:\n    decision = left_job.get(\"mirror_decision\")\n    return isinstance(decision, dict) and decision.get(\"approved\") is True","tryCatchPattern":null,"preventionTips":["Never mark running-left complete by hand; run the derive script so it records an approved mirror_decision.","Treat the visual review + --confirm-appropriate-mirror + --decision-note as mandatory.","Validate mirror_decision before invoking finalize."],"tags":["hatch-pet","mirror","provenance","review","manifest"],"backgroundTag":null,"analyzedSha":"5be4028344c2eb4c667c5a97bda8f750c5597ef7","analyzedAt":"2026-08-12T12:03:58.812Z","schemaVersion":2},"datasetVersion":"2026-08-12T18:17:37.767Z"}