{"record":{"id":"3b4c7fafcf3b5210","repo":"Hmbown/CodeWhale","slug":"invalid-update-archive-index","errorCode":null,"errorMessage":"Invalid update archive index.","messagePattern":"Invalid update archive index\\.","errorType":"exception","errorClass":"Error","httpStatus":null,"severity":"error","filePath":"crates/tui/plugins/computer-use/app/updates.mjs","lineNumber":55,"sourceCode":"  const asset=release.assets?.find(asset=>asset.name===name);\n  const url=`${repository}/releases/download/v${version}/${name}`;\n  if(!asset||asset.browser_download_url!==url||!/^sha256:[a-f0-9]{64}$/.test(asset.digest)||!Number.isSafeInteger(asset.size)||asset.size<=0||asset.size>limit) return {available:false,message:`Version ${version} has no verified macOS installer yet.`};\n  return {available:true,version,url,sha256:asset.digest.slice(7),size:asset.size,message:`Computer Use ${version} is available. Install it to restart the helper; existing computer sessions will stop.`};\n}\nexport async function checkForUpdate() {\n  const response=await fetch(\"https://api.github.com/repos/Hmbown/codewhale-cu-plugin/releases/latest\",{redirect:\"error\",headers:{Accept:\"application/vnd.github+json\",\"X-GitHub-Api-Version\":\"2022-11-28\"},signal:AbortSignal.timeout(10_000)});\n  if(response.status===404) return {available:false,message:\"No stable installer has been published yet. Your current app is unchanged.\"};\n  if(!response.ok) throw new Error(`The update service is unavailable (${response.status}). Try again later.`);\n  return releaseUpdate(JSON.parse((await responseBytes(response,1024*1024)).toString(\"utf8\")));\n}\n\n/** Inspect both ZIP headers before extraction: no links, traversal or bombs. */\nexport function validateReleaseZip(bytes) {\n  const minimum=Math.max(0,bytes.length-65557); let end=-1;\n  for(let i=bytes.length-22;i>=minimum;i--) if(bytes.readUInt32LE(i)===0x06054b50&&i+22+bytes.readUInt16LE(i+20)===bytes.length) { end=i; break; }\n  if(end<0||bytes.readUInt16LE(end+4)||bytes.readUInt16LE(end+6)) throw new Error(\"Invalid update archive.\");\n  const count=bytes.readUInt16LE(end+10); let position=bytes.readUInt32LE(end+16),total=0;\n  if(!count||count>2000||bytes.readUInt16LE(end+8)!==count||position+bytes.readUInt32LE(end+12)!==end) throw new Error(\"Invalid update archive index.\");\n  const seen=new Set();\n  for(let i=0;i<count;i++) {\n    if(position+46>end||bytes.readUInt32LE(position)!==0x02014b50) throw new Error(\"Invalid update entry.\");\n    const flags=bytes.readUInt16LE(position+8),method=bytes.readUInt16LE(position+10),length=bytes.readUInt16LE(position+28),extra=bytes.readUInt16LE(position+30),comment=bytes.readUInt16LE(position+32);\n    const name=bytes.subarray(position+46,position+46+length).toString(\"utf8\");\n    const kind=(bytes.readUInt32LE(position+38)>>>16)&0xf000,offset=bytes.readUInt32LE(position+42),compressed=bytes.readUInt32LE(position+20);\n    const size=bytes.readUInt32LE(position+24); total+=size;\n    if(flags&1||![0,8].includes(method)||![0,0x4000,0x8000].includes(kind)||total>512*1024*1024||position+46+length+extra+comment>end) throw new Error(\"Unsupported update entry.\");\n    if(!name.startsWith(`${APP_NAME}.app/`)||name.includes(\"\\\\\")||name.includes(\":\")||name.includes(\"\\0\")||name.split(\"/\").some(part=>part===\"..\"||part===\".\")||seen.has(name)) throw new Error(\"Unsafe update path.\");\n    seen.add(name);\n    if(offset+30>position||bytes.readUInt32LE(offset)!==0x04034b50) throw new Error(\"Invalid update file header.\");\n    const localLength=bytes.readUInt16LE(offset+26),localExtra=bytes.readUInt16LE(offset+28);\n    if(offset+30+localLength+localExtra+compressed>bytes.readUInt32LE(end+16)||bytes.subarray(offset+30,offset+30+localLength).toString(\"utf8\")!==name) throw new Error(\"Inconsistent update file header.\");\n    if(bytes.readUInt16LE(offset+8)!==method||bytes.readUInt16LE(offset+6)!==flags||(!(flags&8)&&(bytes.readUInt32LE(offset+18)!==compressed||bytes.readUInt32LE(offset+22)!==size))) throw new Error(\"Inconsistent update sizes or compression.\");\n    const start=offset+30+localLength+localExtra;\n    // Header sizes are untrusted. Bound actual expansion before ditto writes\n    // anything, including a compressed payload whose headers understate size.\n    const payload=bytes.subarray(start,start+compressed);","sourceCodeStart":37,"sourceCodeEnd":73,"githubUrl":"https://github.com/Hmbown/CodeWhale/blob/73e0f67d83c59909b571efdfc88c4bc28c309cb1/crates/tui/plugins/computer-use/app/updates.mjs#L37-L73","documentation":"After locating the EOCD, validateReleaseZip parses the central directory: entry count must be 1–2000, the on-disk count must match the EOCD count, and the central-directory offset plus size must land exactly on the EOCD. Any mismatch throws 'Invalid update archive index.', indicating a corrupt or maliciously crafted directory structure.","triggerScenarios":"Calling validateReleaseZip on an archive with zero entries, more than 2000 entries, a central-directory count inconsistent with the EOCD, or an offset+size that does not end at the EOCD — typical of truncation or hand-crafted hostile ZIPs.","commonSituations":"Truncated/partially extracted download cutting off the central directory; attacker-supplied archive with a lying index (ZIP-bomb precursor); a packaging tool emitting inconsistent metadata; an empty release archive shipped by mistake.","solutions":["Re-download and SHA-256-verify the release asset before validating","Compare the asset's byte size against the release metadata's declared size (checkForUpdate already validates this) — a mismatch means truncation","Rebuild the archive with a standard tool (zip -r) if it was produced by a custom packer emitting inconsistent metadata","Reject the update and keep the current install — the parser intentionally fails closed"],"exampleFix":"// before (validate without size cross-check)\ncode.validateReleaseZip(bytes);\n// after (cross-check declared size first)\nif (bytes.length !== releaseInfo.size) throw new Error(\"archive size differs from release metadata\");\ncode.validateReleaseZip(bytes);","handlingStrategy":"validation","validationCode":"function centralDirectorySane(bytes, eocd) {\n  const count = bytes.readUInt16LE(eocd + 10);\n  const size = bytes.readUInt32LE(eocd + 12), off = bytes.readUInt32LE(eocd + 16);\n  return count > 0 && count <= 2000 && off + size === eocd;\n}","typeGuard":null,"tryCatchPattern":"try {\n  validateReleaseZip(bytes);\n} catch (e) {\n  if (e.message.includes(\"archive index\")) {\n    quarantineArchive(bytes); // inconsistent index; treat as hostile\n  } else throw e;\n}","preventionTips":["Cross-check downloaded byte size against release metadata size before validation","Build archives with standard tooling so counts/offsets are consistent","Keep entry counts within the 2000 limit enforced by the validator","Fail closed on index mismatches — never attempt extraction of a lying ZIP"],"tags":["zip","validation","security","corrupt-archive"],"backgroundTag":"checksum-mismatch","analyzedSha":"73e0f67d83c59909b571efdfc88c4bc28c309cb1","analyzedAt":"2026-09-22T01:30:00.501Z","contentChangedAt":"2026-09-22T01:30:00.501Z","schemaVersion":2},"datasetVersion":"2026-09-23T08:17:48.524Z"}