{"record":{"id":"4a1c20cc4e329795","repo":"RocketChat/Rocket.Chat","slug":"invalid-view","errorCode":null,"errorMessage":"invalid view","messagePattern":"invalid view","errorType":"exception","errorClass":"Error","httpStatus":500,"severity":"error","filePath":"apps/meteor/server/modules/core-apps/cloudAnnouncements.module.ts","lineNumber":63,"sourceCode":"\t\treturn this.handlePayload(payload);\n\t}\n\n\tviewSubmit(payload: UiKitCoreAppViewSubmitPayload): Promise<UiKit.ServerInteraction | undefined> {\n\t\treturn this.handlePayload(payload);\n\t}\n\n\tasync viewClosed(payload: UiKitCoreAppViewClosedPayload): Promise<UiKit.ServerInteraction | undefined> {\n\t\tconst {\n\t\t\tpayload: { view: { viewId, id } = {} },\n\t\t\tuser: { _id: userId } = {},\n\t\t} = payload;\n\n\t\tif (!userId) {\n\t\t\tthrow new Error('invalid user');\n\t\t}\n\n\t\tif (!id && !viewId) {\n\t\t\tthrow new Error('invalid view');\n\t\t}\n\n\t\tif (!payload.triggerId) {\n\t\t\tthrow new Error('invalid triggerId');\n\t\t}\n\n\t\t// For backwards compatibility: we prefer to use viewId, but some legacy banners\n\t\t// may only have id. We fetch all matching banners and prioritize viewId match.\n\t\tconst bannerIds = [viewId, id].filter((bannerId) => isTruthy(bannerId));\n\t\tconst banners = await Banners.findByIds(bannerIds).toArray();\n\t\tconst announcement = banners.find((b) => b._id === viewId) || banners.find((b) => b._id === id);\n\t\tif (!announcement) {\n\t\t\tthrow new Error('Banner not found');\n\t\t}\n\n\t\tawait Banner.dismiss(userId, announcement._id);\n\n\t\tconst type = announcement.surface === 'banner' ? 'banner.close' : 'modal.close';","sourceCodeStart":45,"sourceCodeEnd":81,"githubUrl":"https://github.com/RocketChat/Rocket.Chat/blob/b2c16d5842cbe6b69b59bdf6fc5e5f1afcd1f0b0/apps/meteor/server/modules/core-apps/cloudAnnouncements.module.ts#L45-L81","documentation":"`CloudAnnouncementsModule.viewClosed` throws `Error('invalid view')` when neither `payload.payload.view.viewId` nor `payload.payload.view.id` is present. The module accepts both on purpose: `viewId` is preferred, but legacy announcement banners may only carry `id`; when both are absent it cannot resolve which banner to dismiss.","triggerScenarios":"A viewClosed interaction for `cloud-announcements-core` whose `view` object is undefined or contains neither `viewId` nor `id` — e.g. an empty `view: {}`, a malformed modal payload, or fields lost during serialization.","commonSituations":"Reusing a modal-close payload shape that nests the id elsewhere; test fixtures with only a triggerId; payload transformations that strip the view object.","solutions":["Send the announcement banner's identifier as `payload: { view: { viewId: bannerId } }` (use `id` only for legacy banners).","Re-fetch the current banners for the user and dismiss using the live banner `_id`.","For programmatic dismissal, call `Banner.dismiss(userId, bannerId)` directly."],"exampleFix":"// before\npayload: { view: {}, triggerId }\n\n// after\npayload: { view: { viewId: bannerId }, triggerId }","handlingStrategy":"validation","validationCode":"const { view } = payload.payload ?? {};\nif (!view?.viewId && !view?.id) {\n  throw new Error('view.viewId (or legacy view.id) is required');\n}\nawait announcementsModule.viewClosed(payload);","typeGuard":"const hasViewIdentifier = (\n  payload: UiKitCoreAppViewClosedPayload,\n): payload is UiKitCoreAppViewClosedPayload & { payload: { view: { viewId?: string; id?: string } } } =>\n  Boolean(payload.payload?.view && (payload.payload.view.viewId || payload.payload.view.id));","tryCatchPattern":"try {\n  await announcementsModule.viewClosed(payload);\n} catch (error) {\n  if (error instanceof Error && error.message === 'invalid view') {\n    // refetch banners and rebuild the payload with the live banner id\n  }\n}","preventionTips":["Send viewId; keep view.id only for legacy banners","Refetch current banners before building close payloads","Never send an empty view object"],"tags":["uikit","cloud","announcements","payload-validation","core-apps"],"backgroundTag":"uikit-interaction-payload-invalid","analyzedSha":"b2c16d5842cbe6b69b59bdf6fc5e5f1afcd1f0b0","analyzedAt":"2026-08-18T15:26:39.429Z","contentChangedAt":"2026-08-18T15:26:39.429Z","schemaVersion":2},"datasetVersion":"2026-09-14T00:17:10.932Z"}