{"record":{"id":"837cb64b5484bf40","repo":"phacility/phabricator","slug":"you-can-not-request-verification-of-this-commit-be-837cb6","errorCode":null,"errorMessage":"You can not request verification of this commit because no auditors have raised concerns with it.","messagePattern":"You can not request verification of this commit because no auditors have raised concerns with it\\.","errorType":"validation","errorClass":"Exception","httpStatus":null,"severity":"warning","filePath":"src/applications/diffusion/xaction/DiffusionCommitVerifyTransaction.php","lineNumber":51,"sourceCode":"\n  public function getActionName() {\n    return pht('Requested Verification');\n  }\n\n  public function applyInternalEffects($object, $value) {\n    $object->setAuditStatus(DiffusionCommitAuditStatus::NEEDS_VERIFICATION);\n  }\n\n  protected function validateAction($object, PhabricatorUser $viewer) {\n    if (!$this->isViewerCommitAuthor($object, $viewer)) {\n      throw new Exception(\n        pht(\n          'You can not request verification of this commit because you '.\n          'are not the author.'));\n    }\n\n    if (!$object->isAuditStatusConcernRaised()) {\n      throw new Exception(\n        pht(\n          'You can not request verification of this commit because no '.\n          'auditors have raised concerns with it.'));\n    }\n  }\n\n  public function getTitle() {\n    return pht(\n      '%s requested verification of this commit.',\n      $this->renderAuthor());\n  }\n\n  public function getTitleForFeed() {\n    return pht(\n      '%s requested verification of %s.',\n      $this->renderAuthor(),\n      $this->renderObject());\n  }","sourceCodeStart":33,"sourceCodeEnd":69,"githubUrl":"https://github.com/phacility/phabricator/blob/5720a38cfe95b00ca4be5016dd0d2f3195f4fa04/src/applications/diffusion/xaction/DiffusionCommitVerifyTransaction.php#L33-L69","documentation":"The second Verify guard: verification only applies after auditors raised concerns, i.e. the commit's audit status is CONCERN_RAISED. With no standing concerns there is nothing to verify, so the author's Request Verification transaction is rejected.","triggerScenarios":"The author clicks Request Verification on a commit whose audit status is anything other than Concern Raised - e.g. already fully audited, or already in Needs Verification.","commonSituations":"Authors clicking verify preemptively after adding auditors; a second verification request after the status already moved to Needs Verification.","solutions":["Follow the loop in order: an auditor must Raise Concern first, then the author can request verification","Refresh the commit page - if the status already reads Needs Verification, the request already happened","If concerns were resolved another way, use comments or auditor edits rather than the verify action"],"exampleFix":null,"handlingStrategy":"validation","validationCode":"if (!$object->isAuditStatusConcernRaised()) {\n  // verification not applicable yet; do not apply the transaction\n}","typeGuard":null,"tryCatchPattern":null,"preventionTips":["Only offer Request Verification when the commit status is Concern Raised","Document the loop: concern (auditor) -> verify (author) -> re-audit"],"tags":["phabricator","audit","diffusion","state-machine","workflow-order"],"backgroundTag":"invalid-state-transition","analyzedSha":"5720a38cfe95b00ca4be5016dd0d2f3195f4fa04","analyzedAt":"2026-08-21T05:07:25.672Z","schemaVersion":2},"datasetVersion":"2026-08-21T11:28:35.574Z"}