{"record":{"id":"933a1546eec953cf","repo":"instructure/canvas-lms","slug":"peer-review-due-date-cannot-be-after-assignment-until-date","errorCode":null,"errorMessage":"Peer review due date cannot be after assignment until date","messagePattern":"Peer review due date cannot be after assignment until date","errorType":"validation","errorClass":"PeerReview::InvalidDatesError","httpStatus":null,"severity":"error","filePath":"app/services/peer_review/validations.rb","lineNumber":189,"sourceCode":"      raise PeerReview::InvalidDatesError,\n            is_override ? I18n.t(\"Peer review override due date cannot be before parent override available from date\") : I18n.t(\"Peer review due date cannot be before assignment available from date\")\n    end\n\n    # Validate: parent due_at <= child due_at\n    if parent_due_at && child_due_at && parent_due_at > child_due_at\n      raise PeerReview::InvalidDatesError,\n            is_override ? I18n.t(\"Peer review override due date cannot be before parent override due date\") : I18n.t(\"Peer review due date cannot be before assignment due date\")\n    end\n\n    # Validate: child due_at <= parent lock_at\n    if child_due_at && parent_lock_at && child_due_at > parent_lock_at\n      raise PeerReview::InvalidDatesError,\n            is_override ? I18n.t(\"Peer review override due date cannot be after parent override until date\") : I18n.t(\"Peer review due date cannot be after assignment until date\")\n    end\n\n    # Validate: child lock_at <= parent lock_at\n    if child_lock_at && parent_lock_at && child_lock_at > parent_lock_at\n      raise PeerReview::InvalidDatesError,\n            is_override ? I18n.t(\"Peer review override until date cannot be after parent override until date\") : I18n.t(\"Peer review until date cannot be after assignment until date\")\n    end\n  end\n\n  def validate_set_type_required(set_type)\n    raise PeerReview::SetTypeRequiredError, I18n.t(\"Set type is required\") unless set_type.present?\n  end\n\n  def validate_set_id_required(set_id)\n    raise PeerReview::SetIdRequiredError, I18n.t(\"Set id is required\") unless set_id.present?\n  end\n\n  def validate_override_exists(override)\n    raise PeerReview::OverrideNotFoundError, I18n.t(\"Override does not exist\") unless override.present?\n  end\n\n  def validate_section_exists(section)\n    raise PeerReview::SectionNotFoundError, I18n.t(\"Section does not exist\") unless section.present?","sourceCodeStart":171,"sourceCodeEnd":207,"githubUrl":"https://github.com/instructure/canvas-lms/blob/1c9f0bb8013ed69c4f2efe11fd483025469b7e6c/app/services/peer_review/validations.rb#L171-L207","documentation":"PeerReview::InvalidDatesError raised by validate_dates_within_parent_boundaries for the non-override path: the peer review due_at is after the parent assignment's until (lock_at) date. Canvas requires assignment due/until boundaries to contain peer review dates. Same check as error 570 but with is_override=false.","triggerScenarios":"Calling validate_peer_review_dates_against_parent_assignment (via PeerReviewCommonService) with peer_review_dates.due_at > parent_assignment.lock_at; also reachable via validate_override_dates_against_parent_override when is_override is false is not possible, so this variant comes from assignment-level peer review date validation.","commonSituations":"Backdating an assignment lock_at after peer review dates were set; syncing due dates via API without adjusting peer review subassignment dates.","solutions":["Lower the peer review due_at to be <= assignment.lock_at","Raise assignment.lock_at (or leave it nil) so it bounds the peer review due date","Re-run the service after fixing the date ordering"],"exampleFix":"// before\npeer_review_dates = { due_at: Time.zone.parse('2026-11-01') }\nassignment.lock_at = Time.zone.parse('2026-10-15')\n// after\npeer_review_dates = { due_at: Time.zone.parse('2026-10-10') }\nassignment.lock_at = Time.zone.parse('2026-10-15')","handlingStrategy":"validation","validationCode":"raise ArgumentError, 'peer review due_at must be <= assignment.lock_at' if pr_dates[:due_at] && assignment.lock_at && pr_dates[:due_at] > assignment.lock_at","typeGuard":null,"tryCatchPattern":"begin\n  service.validate_peer_review_dates_against_parent_assignment(dates, assignment)\nrescue PeerReview::InvalidDatesError => e\n  Rails.logger.warn(e.message)\n  flash[:error] = e.message\nend","preventionTips":["Compute peer review dates from the assignment dates (e.g. due_at = assignment.lock_at - 1.day) instead of hardcoding","Re-run date validation whenever assignment lock_at changes","Leave assignment.lock_at nil when no hard until boundary is intended"],"tags":["ruby","peer-review","date-validation","canvas"],"backgroundTag":"value-out-of-range","analyzedSha":"1c9f0bb8013ed69c4f2efe11fd483025469b7e6c","analyzedAt":"2026-09-15T20:33:18.891Z","contentChangedAt":"2026-09-15T20:33:18.891Z","schemaVersion":2},"datasetVersion":"2026-09-23T02:17:17.105Z"}