{"record":{"id":"c1f6bed008d40b49","repo":"nikivdev/code","slug":"queued-commit-has-review-issues-fix-them-or-r","errorCode":null,"errorMessage":"Queued commit {} has review issues. Fix them, or re-run with --allow-issues.","messagePattern":"Queued commit (.+?) has review issues\\. Fix them, or re-run with --allow-issues\\.","errorType":"validation","errorClass":null,"httpStatus":null,"severity":"error","filePath":"src/commit.rs","lineNumber":9276,"sourceCode":"                        );\n                        entry\n                    } else {\n                        return Err(err);\n                    }\n                }\n            };\n            let _ = refresh_queue_entry_commit(&repo_root, &mut entry);\n\n            let issues_present = entry.review_issues_found\n                || entry\n                    .review\n                    .as_deref()\n                    .map(|s| !s.trim().is_empty())\n                    .unwrap_or(false);\n            let unreviewed = entry.version >= 2 && !entry.review_completed;\n\n            if issues_present && !allow_issues && !force {\n                bail!(\n                    \"Queued commit {} has review issues. Fix them, or re-run with --allow-issues.\",\n                    short_sha(&entry.commit_sha)\n                );\n            }\n            if unreviewed && !effective_allow_unreviewed && !force {\n                bail!(\n                    \"Queued commit {} does not have a clean review (missing). Re-run review, or re-run with --allow-unreviewed.\",\n                    short_sha(&entry.commit_sha)\n                );\n            }\n            if entry.review_timed_out && !force {\n                eprintln!(\n                    \"note: review timed out for {}; approving anyway (re-run `f commit-queue review {}` if you want a full review)\",\n                    short_sha(&entry.commit_sha),\n                    short_sha(&entry.commit_sha)\n                );\n            }\n","sourceCodeStart":9258,"sourceCodeEnd":9294,"githubUrl":"https://github.com/nikivdev/code/blob/a747e741ae92c09071d0ae946ab48488adcff1ce/src/commit.rs#L9258-L9294","documentation":"Approve-time gate in `run_commit_queue` (src/commit.rs:9276): a queued commit whose stored review recorded issues cannot be approved unless explicitly overridden with `--allow-issues` or `--force`. It protects the pipeline from approving code with known review problems.","triggerScenarios":"`f commit-queue approve <hash>` where the entry's review issues field is non-empty (issues_present) and neither --allow-issues nor --force was passed.","commonSituations":"Reviewer left blocking comments; automated review flagged lint/security issues; user forgot a prior review recorded issues; CI scripts approving without the override flag.","solutions":["Read the entry's review issues (`f commit-queue list` or review output), fix the flagged problems, re-run review, then approve.","If the issues are acceptable, re-run with `--allow-issues`.","Use `--force` to bypass both issue and unreviewed gates when overriding deliberately."],"exampleFix":"// before\nf commit-queue approve 9abc123\n// after (issues acknowledged)\nf commit-queue approve 9abc123 --allow-issues","handlingStrategy":"validation","validationCode":"let entry = find_entry(hash)?;\nlet has_issues = entry.review_issues.as_deref().map(|s| !s.trim().is_empty()).unwrap_or(false);\nif has_issues && !allow_issues && !force {\n    bail!(\"entry {} has review issues; fix or pass --allow-issues\", entry.commit_sha);\n}","typeGuard":"fn review_is_clean(entry: &CommitQueueEntry) -> bool {\n    entry.review_issues.as_deref().map(|s| s.trim().is_empty()).unwrap_or(true)\n}","tryCatchPattern":"match approve_queued(hash) {\n    Err(e) if e.to_string().contains(\"has review issues\") => {\n        eprintln!(\"{e}; inspect review notes, fix, or re-run with --allow-issues\");\n    }\n    other => other?,\n}","preventionTips":["Run `f commit-queue list` to check review state before approving.","Address review issues immediately after review instead of deferring to approve time.","Use --allow-issues/--force only as a conscious, documented override, never in default CI scripts."],"tags":["commit-queue","review-issues","approval-gate"],"backgroundTag":"review-issues-blocking-approval","analyzedSha":"a747e741ae92c09071d0ae946ab48488adcff1ce","analyzedAt":"2026-09-01T22:43:55.719Z","contentChangedAt":null,"schemaVersion":2},"datasetVersion":"2026-09-08T10:18:20.063Z"}