{"record":{"id":"ceec37b430c58036","repo":"JuliusBrussee/caveman","slug":"where-dataset-carries-rolecounts-target-failu","errorCode":null,"errorMessage":"${where} dataset carries ${roleCounts.target_failure} target-failure cases, want ${expectedTargets}","messagePattern":"(.+?) dataset carries (.+?) target-failure cases, want (.+?)","errorType":"exception","errorClass":"Error","httpStatus":null,"severity":"error","filePath":"packages/shared/contracts/scripts/validate-continuous-improvement.mjs","lineNumber":303,"sourceCode":"    //\n    // The boundary and stale-input generators perturb the localization evidence\n    // a confidence guard reads. A ChangeSet whose applicability never reads that\n    // evidence has no threshold to sit beside, so those two cases must NOT be\n    // generated for it — a \"boundary\" case against a guard that does not exist\n    // tests nothing while counting as adversarial coverage.\n    const confidenceGuard = item.change_set.applicability.all.some((condition) =>\n      condition === \"failure_location_confidence >= 0.90\" ||\n      condition === \"symbol_resolution == unique\" ||\n      condition === \"targeted_test_reproduces == true\");\n    const perturbations = new Set(dataset.cases.map((entry) => entry.perturbation));\n    for (const [perturbation, label] of [[\"guard_threshold_boundary\", \"boundary\"], [\"stale_input\", \"stale-input\"]]) {\n      if (perturbations.has(perturbation) !== confidenceGuard) {\n        throw new Error(`${where} ${confidenceGuard ? \"omits\" : \"generated\"} a ${label} case ${confidenceGuard ? \"for\" : \"against\"} a change set that ${confidenceGuard ? \"declares\" : \"declares no\"} confidence guard`);\n      }\n    }\n    const expectedTargets = Math.min(4, dataset.target_failure_cases.length);\n    const expectedPriors = Math.min(2, dataset.prior_success_cases.length);\n    if (roleCounts.target_failure !== expectedTargets) throw new Error(`${where} dataset carries ${roleCounts.target_failure} target-failure cases, want ${expectedTargets}`);\n    if (roleCounts.prior_success !== expectedPriors) throw new Error(`${where} dataset carries ${roleCounts.prior_success} prior-success cases, want ${expectedPriors}`);\n    if (roleCounts.boundary > 1) throw new Error(`${where} dataset carries ${roleCounts.boundary} boundary cases, want at most one`);\n    if (roleCounts.adversarial > (confidenceGuard ? 2 : 1)) throw new Error(`${where} dataset carries ${roleCounts.adversarial} adversarial cases`);\n    if (roleCounts.boundary !== dataset.boundary_cases.length) throw new Error(`${where} boundary case list disagrees with the composed dataset`);\n    if (roleCounts.adversarial !== dataset.generated_cases.length) throw new Error(`${where} generated case list disagrees with the composed dataset`);\n    const composed = roleCounts.target_failure + roleCounts.prior_success + roleCounts.boundary + roleCounts.adversarial;\n    if (composed !== dataset.cases.length) throw new Error(`${where} dataset roles (${composed}) do not account for its ${dataset.cases.length} cases`);\n    if (dataset.replay_case_ids.length !== datasetCaseIDs.size) throw new Error(`${where} replay manifest carries ${dataset.replay_case_ids.length} ids for ${datasetCaseIDs.size} dataset cases`);\n    for (const datasetCaseID of dataset.replay_case_ids) {\n      if (!datasetCaseIDs.has(datasetCaseID)) throw new Error(`${where} replay manifest case ${datasetCaseID} is not a composed dataset case`);\n    }\n\n    // The guard grader exists exactly when there is a perturbed case to catch a\n    // candidate on; a required grader with no case behind it is decoration.\n    const perturbed = dataset.cases.some((entry) => entry.perturbation !== \"none\");\n    if (perturbed !== item.eval_pack.graders.includes(\"guard_respected\")) {\n      throw new Error(`${where} guard_respected grader ${perturbed ? \"missing for\" : \"declared without\"} perturbed dataset cases`);\n    }","sourceCodeStart":285,"sourceCodeEnd":321,"githubUrl":"https://github.com/JuliusBrussee/caveman/blob/27d5a3981a347890211bb1bf2439e5c821a63bc9/packages/shared/contracts/scripts/validate-continuous-improvement.mjs#L285-L321","documentation":"Thrown when the number of dataset cases with role \"target_failure\" does not equal min(4, dataset.target_failure_cases.length). Spec 18.2 caps recorded target-failure replays at four and requires every listed target-failure case to actually appear (with that role) in dataset.cases.","triggerScenarios":"dataset.target_failure_cases lists more or fewer entries than appear with role target_failure in dataset.cases; or more than 4 are replayed, so the composed count (capped at 4) no longer equals the actual count.","commonSituations":"Appending target-failure cases to dataset.cases without updating the target_failure_cases list; listing 5+ failures when the cap is 4.","solutions":["Make target-failure entries in dataset.cases exactly match dataset.target_failure_cases one-for-one, capped at 4.","If more than 4 failures exist, select the 4 to replay and list only those in both places.","Verify each entry's role field is exactly \"target_failure\" (typos create unknown roles and count mismatches)."],"exampleFix":"// before: 5 cases with role \"target_failure\", list has 5\ndataset.target_failure_cases.length = 5   // expectedTargets = 4\n\n// after: keep 4 in both places\ndataset.cases role \"target_failure\" count = 4\ndataset.target_failure_cases.length = 4","handlingStrategy":"validation","validationCode":"const targetCount = dataset.cases.filter((c) => c.role === \"target_failure\").length;\nconst expected = Math.min(4, dataset.target_failure_cases.length);\nconst ok = targetCount === expected;","typeGuard":null,"tryCatchPattern":null,"preventionTips":["Compose dataset.cases and the role lists (target_failure_cases, prior_success_cases, boundary_cases, generated_cases) in one pass so they cannot disagree.","Cap target-failure selection at 4 in the composer, not after."],"tags":["validation","dataset","composition"],"backgroundTag":null,"analyzedSha":"27d5a3981a347890211bb1bf2439e5c821a63bc9","analyzedAt":"2026-08-15T09:26:11.751Z","schemaVersion":2},"datasetVersion":"2026-08-15T17:31:12.345Z"}