{"record":{"id":"ea074f55e83ecd57","repo":"HKUDS/Vibe-Trading","slug":"complete-goals-require-verified-evidence","errorCode":null,"errorMessage":"complete goals require verified evidence","messagePattern":"complete goals require verified evidence","errorType":"validation","errorClass":"ValueError","httpStatus":null,"severity":"error","filePath":"agent/src/goal/store.py","lineNumber":915,"sourceCode":"        return self._claim_from_row(row)\n\n    def _validate_completion_audit(\n        self,\n        goal: GoalRecord,\n        audit: list[AuditRow],\n    ) -> None:\n        criteria = self.list_criteria(goal.goal_id)\n        rows_by_criterion = {row.criterion_id: row for row in audit}\n        for criterion in criteria:\n            if not criterion.required:\n                continue\n            row = rows_by_criterion.get(criterion.criterion_id)\n            if row is None:\n                raise ValueError(f\"missing audit row for criterion {criterion.criterion_id}\")\n            if row.result not in _COMPLETION_RESULTS:\n                raise ValueError(f\"criterion {criterion.criterion_id} is not satisfied\")\n            if row.result in {\"satisfied\", \"satisfied_with_caveat\"} and not row.evidence_ids:\n                raise ValueError(\"complete goals require verified evidence\")\n            if row.result == \"not_applicable_user_accepted\" and not row.notes.strip():\n                raise ValueError(\"not-applicable criteria require acceptance notes\")\n            has_verified_evidence = False\n            for evidence_id in row.evidence_ids:\n                evidence = self._get_evidence(evidence_id)\n                if evidence is None or evidence.goal_id != goal.goal_id:\n                    raise ValueError(f\"unknown evidence_id: {evidence_id}\")\n                if evidence.criterion_id != criterion.criterion_id:\n                    raise ValueError(\n                        f\"evidence {evidence_id} does not match criterion {criterion.criterion_id}\"\n                    )\n                if evidence.verification_status == \"verified\":\n                    has_verified_evidence = True\n            if row.result in {\"satisfied\", \"satisfied_with_caveat\"} and not has_verified_evidence:\n                raise ValueError(\"complete goals require verified evidence\")\n\n    def _get_evidence(self, evidence_id: str) -> EvidenceRecord | None:\n        row = self._conn.execute(","sourceCodeStart":897,"sourceCodeEnd":933,"githubUrl":"https://github.com/HKUDS/Vibe-Trading/blob/80ffdda44c5c4db0dd84d70e051cca591cea67df/agent/src/goal/store.py#L897-L933","documentation":"A completion audit row for a required criterion used result satisfied/satisfied_with_caveat but supplied no evidence_ids. Completed goals must cite evidence for every satisfied criterion.","triggerScenarios":"update_status with an audit row where result is satisfied (or satisfied_with_caveat) and evidence_ids is empty or None.","commonSituations":"Agent declares success narratively without having appended evidence rows; evidence appended to a different goal or criterion; evidence_ids dropped during serialization.","solutions":["append_evidence for the criterion first and put the returned evidence_id(s) in the audit row","If no artifact backs the criterion, it cannot be marked satisfied — either produce evidence or mark it not_applicable_user_accepted with notes","Add a builder check that every satisfied row has non-empty evidence_ids"],"exampleFix":"// before\nAuditRow(criterion_id=\"c1\", result=\"satisfied\", evidence_ids=[])\n// after\nev = store.append_evidence(session_id, goal_id, criterion_id=\"c1\", ...)\nAuditRow(criterion_id=\"c1\", result=\"satisfied\", evidence_ids=[ev.evidence_id])","handlingStrategy":"validation","validationCode":"for row in audit:\n    if row.result in {\"satisfied\", \"satisfied_with_caveat\"}:\n        assert row.evidence_ids, f\"{row.criterion_id} satisfied without evidence\"","typeGuard":"def satisfied_rows_have_evidence(audit: list) -> bool:\n    return all(r.evidence_ids for r in audit if r.result in {\"satisfied\", \"satisfied_with_caveat\"})","tryCatchPattern":"except ValueError as e: if 'require verified evidence' in str(e): append evidence, rebuild audit, retry once","preventionTips":["Make evidence append a prerequisite step in the completion workflow","Never hand-write audit rows without evidence ids","Assert non-empty evidence_ids in audit builders"],"tags":["goal-store","completion-audit","missing-evidence","python"],"backgroundTag":"missing-required-evidence","analyzedSha":"80ffdda44c5c4db0dd84d70e051cca591cea67df","analyzedAt":"2026-08-28T12:46:38.989Z","schemaVersion":2},"datasetVersion":"2026-08-28T16:17:29.566Z"}