What causes "write to memory succeeds" in gitbutlerapp/gitbutler?

No action needed for users of the library

write to memory succeeds

Error message

write to memory succeeds

What it means

serialize_line() in gitbutler-oplog formats one parsed reflog line and writes the gix signature into an in-memory Vec<u8> with write_to(...).expect("write to memory succeeds"). Writing into a Vec has no file descriptor and cannot fail with io::Error, so this expect is an infallibility annotation, not a runtime check - it documents why the Result is deliberately discarded.

Source

Thrown at crates/gitbutler-oplog/src/reflog.rs:152

            new_oid: new_oid_string.as_str().into(),
            signature,
            message: message.as_str().into(),
        };

        previous_oid = *commit_id;

        log.push_str(&serialize_line(reflog_line));
        log.push('\n');
    }

    log
}

fn serialize_line(line: gix::refs::file::log::LineRef<'_>) -> String {
    let mut sig = Vec::new();
    line.signature
        .write_to(&mut sig)
        .expect("write to memory succeeds");

    format!(
        "{} {} {}\t{}",
        line.previous_oid,
        line.new_oid,
        std::str::from_utf8(&sig).expect("no illformed UTF8"),
        line.message
    )
}

#[cfg(test)]
mod set_target_ref {
    use std::str::FromStr;

    use but_testsupport::{CommandExt, git_at_dir};
    use gix::refs::file::log::LineRef;
    use pretty_assertions::assert_eq;
    use tempfile::tempdir;

View on GitHub (pinned to caf1f223d3)

Solutions

No action needed for users of the library
Contributors: keep it as-is, or express infallibility explicitly (see exampleFix)
Do not 'fix' this by adding real I/O here without also switching the function to error propagation

Example fix

// before
line.signature.write_to(&mut sig).expect("write to memory succeeds");

// after - make infallibility explicit instead of message-based
line.signature.write_to(&mut sig).unwrap_or_else(|err| match err {});

Defensive patterns

Strategy: validation

Prevention

Treat this panic as a code defect, not an environment issue - it cannot fire from user input
Do not replace the in-memory Vec writer with file I/O without adding error propagation
Keep serialization unit tests (the file has a set_target_ref test module) exercising this path

When it happens

Trigger: Any execution of the oplog reflog-serialization path (building reflog strings when snapshots/undo data is recorded). The panic arm is effectively unreachable; only a custom writer implementation that starts erroring could trip it.

Common situations: None user-visible. This is a code-reading/contribution context: reviewers may wonder why the io::Result is ignored, and the expect answers that.

Related errors

AI-assisted analysis of gitbutlerapp/gitbutler@caf1f223d3 (2026-08-20). Data as JSON: /api/errors/ffa0fa97d43afe5d. Report an issue: GitHub.