phacility/phabricator · error · Exception

You can not close this revision because it has not been acce

Error message

You can not close this revision because it has not been accepted. Revisions must be accepted before they can be closed.

What it means

Error "You can not close this revision because it has not been accepted. Revisions must be accepted before they can be closed." thrown in phacility/phabricator.

Source

Thrown at src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php:74

  protected function validateAction($object, PhabricatorUser $viewer) {
    if ($this->hasEditor()) {
      if ($this->getEditor()->getIsCloseByCommit()) {
        // If we're closing a revision because we discovered a commit, we don't
        // care what state it was in.
        return;
      }
    }

    if ($object->isClosed()) {
      throw new Exception(
        pht(
          'You can not close this revision because it has already been '.
          'closed. Only open revisions can be closed.'));
    }

    if (!$object->isAccepted()) {
      throw new Exception(
        pht(
          'You can not close this revision because it has not been accepted. '.
          'Revisions must be accepted before they can be closed.'));
    }

    $config_key = 'differential.always-allow-close';
    if (!PhabricatorEnv::getEnvConfig($config_key)) {
      if (!$this->isViewerRevisionAuthor($object, $viewer)) {
        throw new Exception(
          pht(
            'You can not close this revision because you are not the '.
            'author. You can only close revisions you own. You can change '.
            'this behavior by adjusting the "%s" setting in Config.',
            $config_key));
      }
    }
  }

View on GitHub (pinned to 5720a38cfe)

When it happens

Trigger: Thrown at src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php:74 when the library encounters an invalid state.

Common situations: See trigger scenarios.

AI-assisted analysis of phacility/phabricator@5720a38cfe (2026-08-21). Data as JSON: /api/errors/97684f1aa5248de5. Report an issue: GitHub.