theonedev/onedev · error · ConversionException

Please confirm the password.

Error message

Please confirm the password.

What it means

ConfirmativePasswordPropertyEditor validates a password and its confirmation field during Wicket form conversion. If the main password field has a value but the confirmation field is empty, it throws this ConversionException so the form is rejected with a user-facing message.

Source

Thrown at server-core/src/main/java/io/onedev/server/web/editable/password/ConfirmativePasswordPropertyEditor.java:72

				onPropertyUpdating(target);
			}
			
		});
		inputAgain.add(new OnTypingDoneBehavior() {

			@Override
			protected void onTypingDone(AjaxRequestTarget target) {
				onPropertyUpdating(target);
			}
			
		});
	}

	@Override
	protected String convertInputToValue() throws ConversionException {
		if (input.getConvertedInput() != null) {
			if (inputAgain.getConvertedInput() == null)
				throw new ConversionException(_T("Please confirm the password."));
			else if (!input.getConvertedInput().equals(inputAgain.getConvertedInput()))
				throw new ConversionException(_T("Password and its confirmation should be identical."));
			else
				return input.getConvertedInput();
		} else if (inputAgain.getConvertedInput() != null) {
			throw new ConversionException(_T("Password and its confirmation should be identical."));
		} else {
			return input.getConvertedInput();
		}
	}

	@Override
	public boolean needExplicitSubmit() {
		return true;
	}

}

View on GitHub (pinned to d44925c47c)

Solutions

  1. Type the same password into the confirmation field before submitting.
  2. If building a custom editor, ensure both fields are bound and rendered so the confirmation input is converted.
  3. Adjust UI validation to require confirmation whenever the password field is filled.

Example fix

// before: only password filled
password = "secret"; confirm = null;
// after
password = "secret"; confirm = "secret";
Defensive patterns

Strategy: validation

Validate before calling

function canSubmit(pwd, confirm){ return pwd ? confirm != null : true; }

Prevention

When it happens

Trigger: Submitting a form with this editor where input (password) is non-null but inputAgain (confirm password) was left blank.

Common situations: Users typing a new password but skipping the 'confirm password' field in property editors (e.g. user/admin account forms in OneDev).

Understand the failure class

Background: "must not be empty", "cannot be empty" — required-field validation errors across open-source libraries — this error's family across 41 libraries.

Related errors


AI-assisted analysis of theonedev/onedev@d44925c47c (2026-09-06). Data as JSON: /api/errors/2869ab6ee6331346. Report an issue: GitHub.